[THRIFT-2233] Java compiler should defensively copy its binary inputs

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9
• Fix Version/s: 0.9.2
• Component/s: Java - Compiler
• Patch Info: Patch Available
• Assignee: Andrew Gaul
• Reporter: Andrew Gaul
• Created: 22/Oct/13 06:02
• Updated: 06/Jul/14 04:00
• Resolved: 22/Jun/14 17:48

Description

Currently if someone calls the bufferForField accessor then calls ByteBuffer.get, this mutates the struct's ByteBuffer field. Subsequent calls to bufferForField return the mutated field and thus calls to ByteBuffer.get return unexpected results.

    MyStruct myStruct = ...;
    byte[] array = new byte[myStruct.bufferForValue().capacity()];
    someStruct.bufferForValue().get(array);
    someStruct.bufferForValue().get(array);  // previously, NPE