Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2232

IsSet* broken in Go

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.2
    • Component/s: Go - Compiler
    • Labels:
    • Patch Info:
      Patch Available

      Description

      The various generated IsSetXYZ() methods just check for magic values of their respective fields. This is obviously broken, and also diverges from the implementation in other languages.

      I am willing and able to fix this myself, but I don't want to start on any impl until we can decide on an approach.

      At this point, though, optional fields in Go are basically useless if one's application makes use of the magic "absence" value.

        Attachments

          Activity

            People

            • Assignee:
              jensg Jens Geyer
              Reporter:
              bensigelman Ben Sigelman
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: