[THRIFT-2232] IsSet* broken in Go

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.9.2
• Component/s: Go - Compiler
• Labels: isset
• Patch Info: Patch Available
• Assignee: Jens Geyer
• Reporter: Ben Sigelman
• Created: 21/Oct/13 20:52
• Updated: 07/Apr/14 16:29
• Resolved: 21/Dec/13 19:16

Description

The various generated IsSetXYZ() methods just check for magic values of their respective fields. This is obviously broken, and also diverges from the implementation in other languages.

I am willing and able to fix this myself, but I don't want to start on any impl until we can decide on an approach.

At this point, though, optional fields in Go are basically useless if one's application makes use of the magic "absence" value.