Thrift
  1. Thrift
  2. THRIFT-1915 Multiplexing Services
  3. THRIFT-2144

Cocoa: Client-side support for Multiplexing Services on any Transport and Protocol

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.2
    • Component/s: Cocoa - Library
    • Labels:
    • Patch Info:
      Patch Available

      Description

      The attached patch provides client-side support for multiplexed services as specified at THRIFT-563.

        Issue Links

          Activity

          David Robakowski created issue -
          David Robakowski made changes -
          Field Original Value New Value
          Link This issue is cloned as THRIFT-2110 [ THRIFT-2110 ]
          David Robakowski made changes -
          Component/s Cocoa - Library [ 12312398 ]
          Component/s Erlang - Library [ 12312390 ]
          David Robakowski made changes -
          Description See [THRIFT-563|https://issues.apache.org/jira/browse/THRIFT-563] for Details. The attached patch brings client-side support for multiplexed services as specified at [THRIFT-563|https://issues.apache.org/jira/browse/THRIFT-563] and also some additions to the Thrift Cocoa tutorial from [THRIFT-2116|https://issues.apache.org/jira/browse/THRIFT-2116] relating to the usage with multiplexed services. This patch is tested with the Erlang server implementation from [THRIFT-2110|https://issues.apache.org/jira/browse/THRIFT-2110].
          David Robakowski made changes -
          Link This issue is cloned as THRIFT-563 [ THRIFT-563 ]
          David Robakowski made changes -
          Link This issue is cloned as THRIFT-2110 [ THRIFT-2110 ]
          David Robakowski made changes -
          Attachment thrift-2144_Client-side-support-for-Multiplexing-Services.patch [ 12599415 ]
          David Robakowski made changes -
          Attachment thrift-2144_Tutorial-update-relating-to-the-implementation-of-the-client-side-support-for-multiplexed-services.patch [ 12599416 ]
          David Robakowski made changes -
          Description The attached patch brings client-side support for multiplexed services as specified at [THRIFT-563|https://issues.apache.org/jira/browse/THRIFT-563] and also some additions to the Thrift Cocoa tutorial from [THRIFT-2116|https://issues.apache.org/jira/browse/THRIFT-2116] relating to the usage with multiplexed services. This patch is tested with the Erlang server implementation from [THRIFT-2110|https://issues.apache.org/jira/browse/THRIFT-2110]. The attached [patch|https://issues.apache.org/jira/secure/attachment/12599415/thrift-2144_Client-side-support-for-Multiplexing-Services.patch] brings client-side support for multiplexed services as specified at [THRIFT-563|https://issues.apache.org/jira/browse/THRIFT-563] and also some [additions|https://issues.apache.org/jira/secure/attachment/12599416/thrift-2144_Tutorial-update-relating-to-the-implementation-of-the-client-side-support-for-multiplexed-services.patch] to the Thrift Cocoa tutorial from [THRIFT-2116|https://issues.apache.org/jira/browse/THRIFT-2116] relating to the usage with multiplexed services. This patch is tested with the Erlang server implementation from [THRIFT-2110|https://issues.apache.org/jira/browse/THRIFT-2110].
          Hide
          ASF GitHub Bot added a comment -

          Github user drobakowski commented on the pull request:

          https://github.com/apache/thrift/pull/150#issuecomment-47987834

          Hi @guoyalun,

          before you create a new JIRA ticket, i think this duplicates my ticket THRIFT-2144(https://issues.apache.org/jira/browse/THRIFT-2144) as well as parts of the unmerged PR #49. I'm currently rebasing my closed and unmerged PRs.

          Greets,
          David

          Show
          ASF GitHub Bot added a comment - Github user drobakowski commented on the pull request: https://github.com/apache/thrift/pull/150#issuecomment-47987834 Hi @guoyalun, before you create a new JIRA ticket, i think this duplicates my ticket THRIFT-2144 ( https://issues.apache.org/jira/browse/THRIFT-2144 ) as well as parts of the unmerged PR #49. I'm currently rebasing my closed and unmerged PRs. Greets, David
          Jens Geyer made changes -
          Assignee Jens Geyer [ jensg ]
          Hide
          Jens Geyer added a comment -

          True, didn't remember this one. Thanks David.

          Show
          Jens Geyer added a comment - True, didn't remember this one. Thanks David.
          Hide
          ASF GitHub Bot added a comment -

          GitHub user drobakowski opened a pull request:

          https://github.com/apache/thrift/pull/151

          THRIFT-2144 - Cocoa: Client-side support for Multiplexing Services on any Transport and Protocol

          This pull request provides Cocoa client-side support for multiplexed services as specified at THRIFT-563. Partly extracted from my initial PR https://github.com/apache/thrift/pull/49.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/synlay/thrift THRIFT-2144

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/thrift/pull/151.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #151


          commit 1b6cbda93f10fd38d1e893c17c84d4baedf51f06
          Author: David Robakowski <david.robakowski@synlay.com>
          Date: 2014-07-03T21:26:07Z

          Implement Cocoa client-side support for Multiplexing Services
          on any Transport and Protocol as described
          here: https://issues.apache.org/jira/browse/THRIFT-563


          Show
          ASF GitHub Bot added a comment - GitHub user drobakowski opened a pull request: https://github.com/apache/thrift/pull/151 THRIFT-2144 - Cocoa: Client-side support for Multiplexing Services on any Transport and Protocol This pull request provides Cocoa client-side support for multiplexed services as specified at THRIFT-563 . Partly extracted from my initial PR https://github.com/apache/thrift/pull/49 . You can merge this pull request into a Git repository by running: $ git pull https://github.com/synlay/thrift THRIFT-2144 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/151.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #151 commit 1b6cbda93f10fd38d1e893c17c84d4baedf51f06 Author: David Robakowski <david.robakowski@synlay.com> Date: 2014-07-03T21:26:07Z Implement Cocoa client-side support for Multiplexing Services on any Transport and Protocol as described here: https://issues.apache.org/jira/browse/THRIFT-563
          David Robakowski made changes -
          Attachment thrift-2144_Tutorial-update-relating-to-the-implementation-of-the-client-side-support-for-multiplexed-services.patch [ 12599416 ]
          David Robakowski made changes -
          Attachment thrift-2144_Client-side-support-for-Multiplexing-Services.patch [ 12599415 ]
          Hide
          David Robakowski added a comment -

          Jens Geyer no problem! I removed the initial patch files from this commit to keep better track of possible feature work/rebases. I will also create a new PR with the tutorial updates for this ticket as soon as this ticket gets closed.

          Show
          David Robakowski added a comment - Jens Geyer no problem! I removed the initial patch files from this commit to keep better track of possible feature work/rebases. I will also create a new PR with the tutorial updates for this ticket as soon as this ticket gets closed.
          Hide
          ASF GitHub Bot added a comment -

          Github user drobakowski commented on the pull request:

          https://github.com/apache/thrift/pull/151#issuecomment-48805568

          see #150

          Show
          ASF GitHub Bot added a comment - Github user drobakowski commented on the pull request: https://github.com/apache/thrift/pull/151#issuecomment-48805568 see #150
          Hide
          Jens Geyer added a comment -

          Hi, whats the state of this ticket? Is it ready to be reviewed and merged?

          Show
          Jens Geyer added a comment - Hi, whats the state of this ticket? Is it ready to be reviewed and merged?
          Hide
          David Robakowski added a comment -

          Hi Jens Geyer, I think it's ready to be reviewed. I've already tried to start a discussion for one or the other patch with guoyalun, but unfortunately he didn't respond so far. Please see my issue comment on GitHub.

          Show
          David Robakowski added a comment - Hi Jens Geyer , I think it's ready to be reviewed. I've already tried to start a discussion for one or the other patch with guoyalun, but unfortunately he didn't respond so far. Please see my issue comment on GitHub.
          Hide
          ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/thrift/pull/151

          Show
          ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/151
          Hide
          Jens Geyer added a comment -

          Committed, thanks!

          Show
          Jens Geyer added a comment - Committed, thanks!
          Jens Geyer made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 0.9.2 [ 12324954 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Thrift-Test #31 (See https://builds.apache.org/job/Thrift-Test/31/)
          THRIFT-2144 Client-side support for Multiplexing Services on any Transport and Protocol (jensg: rev aa99e0e2b8b29b75b18b5dfc8e8c17245cb43e75)

          • lib/cocoa/src/protocol/TProtocolDecorator.h
          • lib/cocoa/src/protocol/TMultiplexedProtocol.m
          • lib/cocoa/src/protocol/TMultiplexedProtocol.h
          • lib/cocoa/src/protocol/TProtocolDecorator.m
          Show
          Hudson added a comment - FAILURE: Integrated in Thrift-Test #31 (See https://builds.apache.org/job/Thrift-Test/31/ ) THRIFT-2144 Client-side support for Multiplexing Services on any Transport and Protocol (jensg: rev aa99e0e2b8b29b75b18b5dfc8e8c17245cb43e75) lib/cocoa/src/protocol/TProtocolDecorator.h lib/cocoa/src/protocol/TMultiplexedProtocol.m lib/cocoa/src/protocol/TMultiplexedProtocol.h lib/cocoa/src/protocol/TProtocolDecorator.m
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Thrift #1286 (See https://builds.apache.org/job/Thrift/1286/)
          THRIFT-2144 Client-side support for Multiplexing Services on any Transport and Protocol (jensg: rev aa99e0e2b8b29b75b18b5dfc8e8c17245cb43e75)

          • lib/cocoa/src/protocol/TProtocolDecorator.h
          • lib/cocoa/src/protocol/TProtocolDecorator.m
          • lib/cocoa/src/protocol/TMultiplexedProtocol.m
          • lib/cocoa/src/protocol/TMultiplexedProtocol.h
          Show
          Hudson added a comment - SUCCESS: Integrated in Thrift #1286 (See https://builds.apache.org/job/Thrift/1286/ ) THRIFT-2144 Client-side support for Multiplexing Services on any Transport and Protocol (jensg: rev aa99e0e2b8b29b75b18b5dfc8e8c17245cb43e75) lib/cocoa/src/protocol/TProtocolDecorator.h lib/cocoa/src/protocol/TProtocolDecorator.m lib/cocoa/src/protocol/TMultiplexedProtocol.m lib/cocoa/src/protocol/TMultiplexedProtocol.h
          Jake Farrell made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Thrift #1331 (See https://builds.apache.org/job/Thrift/1331/)
          THRIFT-2144 Client-side support for Multiplexing Services on any Transport and Protocol (jensg: rev aa99e0e2b8b29b75b18b5dfc8e8c17245cb43e75)

          • lib/cocoa/src/protocol/TProtocolDecorator.m
          • lib/cocoa/src/protocol/TMultiplexedProtocol.m
          • lib/cocoa/src/protocol/TMultiplexedProtocol.h
          • lib/cocoa/src/protocol/TProtocolDecorator.h
          Show
          Hudson added a comment - SUCCESS: Integrated in Thrift #1331 (See https://builds.apache.org/job/Thrift/1331/ ) THRIFT-2144 Client-side support for Multiplexing Services on any Transport and Protocol (jensg: rev aa99e0e2b8b29b75b18b5dfc8e8c17245cb43e75) lib/cocoa/src/protocol/TProtocolDecorator.m lib/cocoa/src/protocol/TMultiplexedProtocol.m lib/cocoa/src/protocol/TMultiplexedProtocol.h lib/cocoa/src/protocol/TProtocolDecorator.h
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          403d 10h 1m 1 Jens Geyer 29/Sep/14 21:55
          Resolved Resolved Closed Closed
          2d 4h 43m 1 Jake Farrell 02/Oct/14 02:38

            People

            • Assignee:
              Jens Geyer
              Reporter:
              David Robakowski
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development