[THRIFT-2112] Error in Go generator when using typedefs in map keys

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.9.1
• Component/s: Go - Compiler
• Labels: newbie patch
• Patch Info: Patch Available
• Assignee: Unassigned
• Reporter: Emir Habul
• Created: 03/Aug/13 07:07
• Updated: 19/Aug/13 00:31
• Resolved: 03/Aug/13 08:27

Description

When following is written in .thrift input

  typedef i32 MyType
  typedef map<MyType, i32> ComplexMapType

Generator builds the following:

  type ComplexMapType map[int32]int32

This patch changes the type definition to be

  type ComplexMapType map[MyType]int32

Since, there is really no need to resolve key type from MyType into int32. Compiler would throw error on lines like these:

  complex_var = make(map[MyType]int32, size)

also,

  var _key1 MyType
  ...
  complex_var[_key1] = _val2

Issue Links

• relates to: THRIFT-2063 Go compiler cannot create code for maps with complex/binary keys