Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2079

Expose collection element type information through @property comments.

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Do
    • Affects Version/s: 0.9
    • Fix Version/s: 0.13.0
    • Component/s: Cocoa - Compiler
    • Labels:
    • Patch Info:
      Patch Available

      Description

      Currently there is no easy way to know type information of collections in generated Cocoa thrift classes (due to obj-c collections not being templated).
      This becomes awkward from a documentation point of view as the code is not self documenting and assumptions have to be made by the reader based on the type of elements inside a collection.

      Suggest appending comments after @property declarations to indicate element type, eg:

      @property (nonatomic, retain, getter=newlist, setter=setNewlist NSMutableArray * newlist; // <NSNumber*>

        Attachments

          Activity

            People

            • Assignee:
              jking3 James E. King III
              Reporter:
              zdavison Zachary Davison

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment