[THRIFT-2056] Moved all #include config.h statements to #include <thrift/config.h>

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.10.0
• Component/s: C++ - Library

Environment

All

• Patch Info: Patch Available
• Assignee: Randy Abernethy
• Reporter: Randy Abernethy
• Created: 21/Jun/13 09:00
• Updated: 20/Feb/21 15:28
• Resolved: 08/Apr/16 05:36

Description

This is a follow on to THRIFT-2014.

Everything in the C++ lib is #include <thrift/*> except the config.h. The attached patch changes all config.h includes to #include <thrift/config.h>.
This patch also creates a default thrift/config.h which is empty except for a _WIN32 guarded include of thrift/windows/config.h. This will be overwritten by configure/make/make install on *nix but will allow Windows users to just copy the tree and go.

TODO:

---

I have not addressed the HAVE_CONFIG guards yet. By providing an empty config.h I can't see a scenario where HAVE_CONFIG is needed. Unless anyone can see a reason to leave HAVE_CONFIG around I will remove the guard globally in a new patch.

Issue Links

• duplicates: THRIFT-2039 config.h --> thrift-config.h