Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2056

Moved all #include config.h statements to #include <thrift/config.h>

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.10.0
    • C++ - Library
    • None
    • All

    • Patch Available

    Description

      This is a follow on to THRIFT-2014.

      Everything in the C++ lib is #include <thrift/*> except the config.h. The attached patch changes all config.h includes to #include <thrift/config.h>.
      This patch also creates a default thrift/config.h which is empty except for a _WIN32 guarded include of thrift/windows/config.h. This will be overwritten by configure/make/make install on *nix but will allow Windows users to just copy the tree and go.

      TODO:


      I have not addressed the HAVE_CONFIG guards yet. By providing an empty config.h I can't see a scenario where HAVE_CONFIG is needed. Unless anyone can see a reason to leave HAVE_CONFIG around I will remove the guard globally in a new patch.

      Attachments

        Issue Links

          Activity

            People

              codesf Randy Abernethy
              codesf Randy Abernethy
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: