[THRIFT-2039] config.h --> thrift-config.h

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Component/s: C++ - Library
• Patch Info: Patch Available
• Assignee: Roger Meier
• Reporter: Konrad Grochowski
• Created: 18/Jun/13 13:08
• Updated: 25/Jul/13 03:40
• Resolved: 22/Jun/13 20:21

Description

I've a problem with config.h: I compile thrift lib as a part of bigger project on both linux and windows. single config.h is not working for me. Also: my project does not contain config.h in root dir, so to make

#include "config.h"

in thrift code I need to modify includes path for thrift sources.

I've come out with little workaround: I've added thrift-config.h file which "embeds" autotools config.h and predefined config.h for windows.

#ifdef _WIN32
# include <thrift/windows/config.h>
#else
# include <thrift/config.h>
#endif

and I've changed all occurrences of "config.h" to <thrift/thrift-config.h>

If I knew anything about autotools I'd also add prefixes to defines - like libevent (something like second patch from THRIFT-705)

Issue Links

• is duplicated by: THRIFT-2056 Moved all #include config.h statements to #include <thrift/config.h>