Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2039

config.h --> thrift-config.h

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: C++ - Library
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      I've a problem with config.h: I compile thrift lib as a part of bigger project on both linux and windows. single config.h is not working for me. Also: my project does not contain config.h in root dir, so to make

      #include "config.h"

      in thrift code I need to modify includes path for thrift sources.

      I've come out with little workaround: I've added thrift-config.h file which "embeds" autotools config.h and predefined config.h for windows.

      #ifdef _WIN32
      # include <thrift/windows/config.h>
      #else
      # include <thrift/config.h>
      #endif
      

      and I've changed all occurrences of "config.h" to <thrift/thrift-config.h>

      If I knew anything about autotools I'd also add prefixes to defines - like libevent (something like second patch from THRIFT-705)

        Attachments

        1. windows_thrift_config.patch
          2 kB
          Ben Craig
        2. thrift-config.h
          0.1 kB
          Konrad Grochowski
        3. THRIFT-2039-thrift_config_h.patch
          11 kB
          Konrad Grochowski

          Issue Links

            Activity

              People

              • Assignee:
                roger Roger Meier
                Reporter:
                hcorg Konrad Grochowski
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: