Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2027

Minor 64-bit and NOMINMAX issues in C++ library

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.9
    • Fix Version/s: 0.10.0
    • Component/s: C++ - Library
    • Labels:
      None
    • Environment:

      64-bit. Windows without NOMINMAX set.

    • Patch Info:
      Patch Available

      Description

      TNonblockingServer and THttpServer have size_t -> uint32_t truncations.

      TZlibTransport calls std::min without enclosing it in parens. This is a really minor issue, since we technically build with NOMINMAX in the environment (which fixes the problem), but I have a strange personal goal of being able to build without setting NOMINMAX.

        Attachments

        1. misc_minor.patch
          2 kB
          Ben Craig

          Activity

            People

            • Assignee:
              ben.craig Ben Craig
              Reporter:
              ben.craig Ben Craig
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: