Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-2021

Improve large binary protocol string performance

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.9
    • Fix Version/s: 0.10.0
    • Component/s: C++ - Library
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      Currently, TBinaryProtocol reads into a temporary buffer, then copies the results into the resulting std::string. For large strings (like a megabyte), the copy can be a performance issue.

      The attached patch reads directly into the std::string instead.

        Attachments

          Activity

            People

            • Assignee:
              ben.craig Ben Craig
              Reporter:
              ben.craig Ben Craig

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment