[THRIFT-2021] Improve large binary protocol string performance

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9
• Fix Version/s: 0.10.0
• Component/s: C++ - Library
• Patch Info: Patch Available
• Assignee: Ben Craig
• Reporter: Ben Craig
• Created: 13/Jun/13 13:59
• Updated: 12/Aug/16 01:29
• Resolved: 08/Apr/16 05:36

Description

Currently, TBinaryProtocol reads into a temporary buffer, then copies the results into the resulting std::string. For large strings (like a megabyte), the copy can be a performance issue.

The attached patch reads directly into the std::string instead.