[THRIFT-2016] Resource Leak in thrift struct under compiler/cpp/src/parse/t_function.h

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9
• Fix Version/s: 0.9.2
• Component/s: C++ - Compiler
• Labels: patch

Environment

cpp compiler of thrift 0.9.0 on Linux 2.6.32-220.el6.x86_64

• Patch Info: Patch Available
• Assignee: Unassigned
• Reporter: kuldeep gupta
• Created: 13/Jun/13 12:28
• Updated: 10/Jul/14 13:42
• Resolved: 10/Jul/14 13:42

Description

In file compiler/cpp/src/parse/t_function.h

class t_function : public t_doc {
35 public:
36 t_function(t_type* returntype,
37 std::string name,
38 t_struct* arglist,
39 bool oneway=false) :
40 returntype_(returntype),
41 name_(name),
42 arglist_(arglist),
43 oneway_(oneway)

{ 44 xceptions_ = new t_struct(NULL); In Line number 44 1. Allocating memory by calling "new t_struct(NULL)". 2. Assigning "this->xceptions_" = "new t_struct(NULL)". 3. The constructor allocates field "xceptions_" of "t_function" but the destructor and whatever functions it calls do not free it. 45 }

This is the destructor implementation.
63 ~t_function() {}

destructor should deallocate memroy for xceptions_. but destructor implementation does not do resource deallocation.
which sometimes causes Resource Leak.

Possible patch:
~t_function() {
delete xceptions_;
xceptions_ = NULL;
}