[THRIFT-1996] JavaME Constants generation is broken / inconsistent with regular Java generation

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.9
• Fix Version/s: 0.9.1
• Component/s: JavaME - Compiler

Environment

NA

• Patch Info: Patch Available
• Assignee: Unassigned
• Reporter: Matthew Rathbone
• Created: 04/Jun/13 21:43
• Updated: 10/Jun/13 18:56
• Resolved: 08/Jun/13 03:15

Description

So say you have a namespace 'com.example', and in this namespace you have constant definitions in multiple files:

Example1.thrift, Example2.thrift

Generating either of these files compiles to com/example/Constants.java

So you cannot have more than one file containing constants in this namespace, as compiling Example2 overrides the code compiled from Example1.

In the regular java codegen the compile paths are different:

Example1.thrift => Example1Constants.java
Example2.thrift => Example2Constants.java

This seems to be the optimal solution as losing code is never good. I've patched the Javame compiler to act the same as the Java compiler (will attach a patch)

Issue Links

• is related to: THRIFT-1977 C# compiler should generate constant files prefixed with thrift file name