[THRIFT-1980] Modernize Go tooling, fix go client libary.

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.9.1
• Component/s: Go - Compiler, Go - Library
• Patch Info: Patch Available
• Assignee: Unassigned
• Reporter: Travis Cline
• Created: 27/May/13 11:18
• Updated: 20/Feb/21 15:27
• Resolved: 09/Jun/13 02:12

Description

This patch improves some of the Go tooling to get it inline with modern (post-1.0) go development practices.

As of go1 (go1.1 is current) 'gomake' et al are missing and Go code should be built and installed via the go tool. (see http://golang.org/cmd/go/)

It removes the generated Makefiles as they are no longer used for go development.

Along those lines, the patch also encourages the use of go get to install the go client library (currently pointing to the github mirror). Not using 'go get' is non-idiomatic for go development and we should support and encourage installing via go get.

It also starts including running go tests as part of 'make check'.

Patches:
0001-THRIFT-1980-Go-Modernize-go-tooling.-Update-autoconf.patch - initial patch to move away from makefiles and to encourage go get
0002-Integrate-changes-from-github.com-pomack-thrift4go.patch - update the client code from pomack's github fork (@ 4e1ad38)
0003-Update-tutorial-code-for-go1.patch - update tutorial/go code for go1
0004-Fix-imports-add-package-prefixes-configurable-thrift.patch - fix generated go code to not create additional, bad import statements

This work is mirrored at https://github.com/traviscline/thrift

Issue Links

• is depended upon by: THRIFT-2011 Go JSON reads/writes incorrect data for list<>
• is depended upon by: THRIFT-2007 Go generated code may fail with "illegal UTF-8 sequence" at "go run"
• is depended upon by: THRIFT-2008 Go comment missing linebreaks
• is superceded by: THRIFT-2012 Modernizing Go
• relates to: THRIFT-2009 Go redeclaration error