Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1980

Modernize Go tooling, fix go client libary.

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.1
    • Component/s: Go - Compiler, Go - Library
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      This patch improves some of the Go tooling to get it inline with modern (post-1.0) go development practices.

      As of go1 (go1.1 is current) 'gomake' et al are missing and Go code should be built and installed via the go tool. (see http://golang.org/cmd/go/)

      It removes the generated Makefiles as they are no longer used for go development.

      Along those lines, the patch also encourages the use of go get to install the go client library (currently pointing to the github mirror). Not using 'go get' is non-idiomatic for go development and we should support and encourage installing via go get.

      It also starts including running go tests as part of 'make check'.

      Patches:
      0001-THRIFT-1980-Go-Modernize-go-tooling.-Update-autoconf.patch - initial patch to move away from makefiles and to encourage go get
      0002-Integrate-changes-from-github.com-pomack-thrift4go.patch - update the client code from pomack's github fork (@ 4e1ad38)
      0003-Update-tutorial-code-for-go1.patch - update tutorial/go code for go1
      0004-Fix-imports-add-package-prefixes-configurable-thrift.patch - fix generated go code to not create additional, bad import statements

      This work is mirrored at https://github.com/traviscline/thrift

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                traviscline Travis Cline
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: