Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1942

Binary accelerated cpp extension does not use Thrift namespaces for Exceptions

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 0.9
    • 0.9.1
    • None
    • Patch Available

    Description

      When an Exception is required to be thrown by the binary accelerated library, an Class Not Found error will occur:

      PHP Fatal error: Class 'TProtocolException' not found in XXXX

      Line 426 needs to change from
      createObject("TProtocolException", ex, 2, zwhat, zerrorcode);
      to
      createObject("\\Thrift\\Exception
      TProtocolException", ex, 2, zwhat, zerrorcode);

      and line 1104 needs to change from
      createObject("TApplicationException", ex);
      to
      createObject("\\Thrift\\Exception
      TApplicationException", ex);

      Basically, there is no accounting for the fact that the exception classes are now namespaced.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            thobbs Tom Hobbs
            jeremy.rayner Jeremy Rayner
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment