[THRIFT-1881] TNonblockingServer does not release open connections or threads on shutdown

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.9.1
• Component/s: C++ - Library
• Labels: patch

Environment

Centos 6.3/Windows 7

• Patch Info: Patch Available
• Assignee: Roger Meier
• Reporter: Randy Abernethy
• Created: 13/Mar/13 13:40
• Updated: 20/Feb/21 15:27
• Resolved: 08/Jun/13 03:15

Description

TNonblockingServer fails to release active TConnections on shutdown (per comments in the code). An important side effect is that the connection owned resources are not freed, in particular destructor clean up code in user defined service handlers. Also the interdependency between Threads and TNonblockingIOThreads via shared_ptr causes all of these objects to leak. This patch reduces the leaked heap blocks from > 100 to 1 on my test machines using an assortment of threads and terminal connection states.