Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1846

Restore socket.h header to support builds with Android NDK

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.9
    • 0.9.1
    • C++ - Library
    • None
    • Building with Android Linux NDK R8D (and, it looks like, all previous NDKs)

    • Patch Available

    Description

      Unlike every other rational un.h that I've seen, the sys/un.h (actually linux/un.h) distributed with the Android NDK doesn't define sa_family_t or include another header that does. Removal of socket.h in THRIFT-1740 broke the Android build.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            nicolastr Nicolas Trésegnie
            nater Nate Rosenblum
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment