[THRIFT-1815] Code generators line buffer output

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9
• Fix Version/s: 0.9.1, 0.9.2
• Component/s: Compiler (General)
• Labels: performance
• Patch Info: Patch Available
• Assignee: Unassigned
• Reporter: Andrew Gaul
• Created: 31/Dec/12 06:40
• Updated: 11/Nov/13 20:43
• Resolved: 02/Nov/13 18:07

Description

This results in slow performance on FUSE- and network-based filesystems, e.g., eCryptfs. std::ostream << std::endl emits a newline and flushes buffers to the kernel[1], yielding excessive system calls. Instead, emit "\n" which does the equivalent without the flush[2]. The attached patch accomplishes this while minimizing code churn by removing "using namespace std" and introducing a static variable endl.

[1] http://www.cplusplus.com/reference/ios/endl/
[2] http://stackoverflow.com/questions/5492380/what-is-the-c-iostream-endl-fiasco