[THRIFT-1772] Serialization does not check types of embedded structures.

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.8, 0.9
• Fix Version/s: 0.9.2
• Component/s: Python - Library
• Labels: python
• Patch Info: Patch Available
• Assignee: Henrique Mendonca
• Reporter: Avi Flamholz
• Created: 03/Dec/12 16:55
• Updated: 10/Jul/14 13:42
• Resolved: 10/Jul/14 13:42

Description

Consider the following struct definitions:

struct Point {
1: required double x;
2: required double y;
}

struct Review {
1: required i32 rating;
2: optional string text;
}

struct Place {
1: required string name;
2: required Point location;
3: optional Review review;
}

If I create a Place object and set the location field to a Review, it will serialize no problem.

place = Place(name="avi's place", location=Review(rating=1.0))
transportOut = TTransport.TMemoryBuffer()
protocolOut = TBinaryProtocol.TBinaryProtocol(transportOut)
place.write(protocolOut)
serialized = transportOut.getvalue()

This is confusing because if I set an i32 field to a string serialization does raise an error.

Issue Links

• relates to: THRIFT-1732 Thrift should provide deep-validation of structures