[THRIFT-1755] Comment parsing bug

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9
• Fix Version/s: 0.9.2
• Component/s: Compiler (General)
• Labels: compilation docstrings

Environment

Windows 7

• Patch Info: Patch Available
• Assignee: Jens Geyer
• Reporter: Bud Bundy
• Created: 16/Nov/12 15:52
• Updated: 03/Jan/19 12:27
• Resolved: 16/Sep/13 20:19

Description

thrift-0.9.0.exe crashes when trying to parse a thrift description file with a particular style of comment.

The crash message is:

Assertion failed: docstring.length() <= strlen(doctext), file src/main.cc, line 548

This application has requested the Runtime to terminate it in an unusual way.
Please contact the application's support team for more information.

Reproducible with the following definitions file:

service myservice
{
	/**SomeTextHere*/
}

Note that if you put a space like so /**SomeTextHere */, it compiles.

Issue Links

• is duplicated by: THRIFT-891 Comments are not properly handled in some cases