[THRIFT-1754] RangeError in buffer handling

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.9
• Fix Version/s: 0.9.3
• Component/s: Node.js - Library

Environment

Ubuntu 12.04, Node.js v0.8.8

• Assignee: Randy Abernethy
• Reporter: Vesa Poikajärvi
• Created: 15/Nov/12 05:55
• Updated: 26/Jan/15 02:26
• Resolved: 18/Nov/14 21:48

Description

I have a Node.js service that connects to multiple Thrift servers (using TFramedTransport with C++ servers and TBufferedTransport with Python servers). Every now and then for reasons rather hard to track the following happens:

buffer.js:242
      this.parent = new SlowBuffer(this.length);
                    ^
RangeError: length > kMaxLength
    at new Buffer (buffer.js:242:21)
    at Socket.TFramedTransport.receiver (/home/me/my_service/node_modules/thrift/lib/thrift/transport.js:59:17)
    at Socket.EventEmitter.emit (events.js:88:17)
    at TCP.onread (net.js:395:14)

Node module is extracted from Thrift 0.9 tarball due to THRIFT-1637. And as mentioned, I cannot really tell what triggers the behavior. When running in development mode I use Forever to relaunch a crashed process, and when it first crashes because of this it will keep relaunching a few times, maybe ten or so (I connect to the services upon startup), and then it starts working again.

Issue Links

• relates to: THRIFT-2205 Node.js Test Server to support test.js JavaScript Browser test and sundry fixes