[THRIFT-1732] Thrift should provide deep-validation of structures

• Type: New Feature
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 0.9
• Component/s: Python - Compiler

Environment

All.

• Patch Info: Patch Available
• Assignee: Kamil Sałaś
• Reporter: Avi Flamholz
• Created: 15/Oct/12 19:54
• Updated: 22/Nov/13 10:57

Description

The validate() method in Python does extremely shallow validation: it checks only that required fields are not None. It does not check that field values have the correct type or that embedded structures or collections are valid.

This is paltry validation as compared to IsInitialized() in the Python Protocol Buffers implementation, which descends into embedded structures and checks that they are valid. Not to mention that ProtocolBuffers also check value types on assignment.

It is fairly simple to generate a deep_validate() method that will recursively descend into structures and collections and call validate() on those which can be validated. I've written something of the sort and I'm curious if it would be a welcome addition to the Python generated code.

Issue Links

• is related to: THRIFT-1772 Serialization does not check types of embedded structures.