[THRIFT-1718] Incorrect check in TFileTransportTest

• Type: Test
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.8
• Fix Version/s: 0.9
• Component/s: C++ - Library
• Patch Info: Patch Available
• Assignee: Diwaker Gupta
• Reporter: Diwaker Gupta
• Created: 09/Oct/12 19:54
• Updated: 10/Oct/12 01:21
• Resolved: 09/Oct/12 20:00

Description

TFileTransport:282, comment says:

" // Make sure TFileTransport called fsync at least once"

However, the test checks for greater than, resulting in failures.

This diff brings the check in line with the comment and fixes the failing tests:

--- lib/cpp/test/TFileTransportTest.cpp
+++ lib/cpp/test/TFileTransportTest.cpp
@@ -278,7 +278,7 @@ void test_flush_max_us_impl(uint32_t flush_us, uint32_t write_us,
   const FsyncLog::CallList* calls = log.getCalls();
   // We added 1 fsync call above.
   // Make sure TFileTransport called fsync at least once
-  BOOST_CHECK_GT(calls->size(),
+  BOOST_CHECK_GE(calls->size(),
                  static_cast<FsyncLog::CallList::size_type>(1));
 
   const struct timeval* prev_time = NULL;