Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1699

Native Union#read has extra read_field_end call

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8
    • Fix Version/s: 0.9.1
    • Component/s: Ruby - Library
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      The native implementation of the Union#read method has an extraneous call to read_field_end. This makes no difference to most protocols because read_field_end is a no-op, but it breaks JSON (in this case my own class, not the one in trunk), which does do something in this method.

        Attachments

        1. rb-struct.diff
          2 kB
          Kevin Radloff
        2. THRIFT-1699-remove-extra-read-field-end.patch
          2 kB
          Nathan Beyer

          Activity

            People

            • Assignee:
              jensg Jens Geyer
              Reporter:
              radsaq Kevin Radloff

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment