Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1699

Native Union#read has extra read_field_end call

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.8
    • 0.9.1
    • Ruby - Library
    • None
    • Patch Available

    Description

      The native implementation of the Union#read method has an extraneous call to read_field_end. This makes no difference to most protocols because read_field_end is a no-op, but it breaks JSON (in this case my own class, not the one in trunk), which does do something in this method.

      Attachments

        1. rb-struct.diff
          2 kB
          Kevin Radloff
        2. THRIFT-1699-remove-extra-read-field-end.patch
          2 kB
          Nathan Beyer

        Activity

          People

            jensg Jens Geyer
            radsaq Kevin Radloff
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: