Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1644

Upgrade RSpec to 2.10.x and refactor specs as needed

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.8
    • 0.9
    • Ruby - Library
    • Patch Available

    Description

      The included patch updates the Ruby library to utilized RSpec 2.10.1. This required some refactoring of the actual specs as they were extending from ExampleGroup, which as far as I can tell is not supported in RSpec 2. There were also a few other changes I had to make to get the specs working, but I believe they maintain the original intent of all specs. There's likely additional clean up and trimming that can be done, but that should happen separately.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            nbeyer Nathan Beyer
            nbeyer Nathan Beyer
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment