Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1636

Can we remove the closing tags from generated PHP sources?

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: PHP - Compiler
    • Labels:
      None

      Description

      Closing PHP tags are unnecessary in virtually all environments and in many cases actually cause problems when not used properly. Right now we're generating the closing tags followed by a newline, if output buffering isn't running at the point that such a source is included, PHP will go ahead and print it.

      In my experience it's best to leave the closing PHP tags off of the end of sources, any objections to removing them here?

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              yelirekim Mike Riley
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: