[THRIFT-1636] Can we remove the closing tags from generated PHP sources?

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: PHP - Compiler
• Assignee: Unassigned
• Reporter: Mike Riley
• Created: 23/Jun/12 01:34
• Updated: 23/Jun/12 01:44

Description

Closing PHP tags are unnecessary in virtually all environments and in many cases actually cause problems when not used properly. Right now we're generating the closing tags followed by a newline, if output buffering isn't running at the point that such a source is included, PHP will go ahead and print it.

In my experience it's best to leave the closing PHP tags off of the end of sources, any objections to removing them here?