Thrift
  1. Thrift
  2. THRIFT-1635

D codegen bug for required non-nullable fields

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: D - Library
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      The attached patches fix handling of structs with non-nullable (as in assignability of null to their D representation), required fields, and add a simple test case to prevent similar stupid mistakes in the future.

      An actual test case for the functionality should be added to the standalone test site at some point (I was absolutely surprised that this is not covered yet), but I can't spare the time to do so right now, and fixing the issue is critical, as it e.g. breaks the HBase Thrift interface for D.

        Activity

        David Nadlinger created issue -
        David Nadlinger made changes -
        Field Original Value New Value
        Attachment 0001-Fixed-D-codegen-for-required-non-nullable-fields.patch [ 12533077 ]
        Attachment 0002-Added-struct-codegen-sanity-tests-directly-to-thrift.patch [ 12533078 ]
        Hide
        Roger Meier added a comment -

        committed

        Show
        Roger Meier added a comment - committed
        Roger Meier made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee David Nadlinger [ klickverbot ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Thrift #505 (See https://builds.apache.org/job/Thrift/505/)
        THRIFT-1635 D codegen bug for required non-nullable fields
        Patch: David Nadlinger (Revision 1353316)

        Result = SUCCESS
        roger : http://svn.apache.org/viewvc/?view=rev&rev=1353316
        Files :

        • /thrift/trunk/lib/d/src/thrift/codegen/base.d
        Show
        Hudson added a comment - Integrated in Thrift #505 (See https://builds.apache.org/job/Thrift/505/ ) THRIFT-1635 D codegen bug for required non-nullable fields Patch: David Nadlinger (Revision 1353316) Result = SUCCESS roger : http://svn.apache.org/viewvc/?view=rev&rev=1353316 Files : /thrift/trunk/lib/d/src/thrift/codegen/base.d
        Jake Farrell made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            David Nadlinger
            Reporter:
            David Nadlinger
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development