[THRIFT-1635] D codegen bug for required non-nullable fields

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Component/s: D - Library
• Patch Info: Patch Available
• Assignee: David Nadlinger
• Reporter: David Nadlinger
• Created: 22/Jun/12 17:49
• Updated: 27/Jul/12 16:05
• Resolved: 24/Jun/12 19:21

Description

The attached patches fix handling of structs with non-nullable (as in assignability of null to their D representation), required fields, and add a simple test case to prevent similar stupid mistakes in the future.

An actual test case for the functionality should be added to the standalone test site at some point (I was absolutely surprised that this is not covered yet), but I can't spare the time to do so right now, and fixing the issue is critical, as it e.g. breaks the HBase Thrift interface for D.