Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1627

compiler built using compilers.vcxproj cannot be used to build some test .thrift files

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 0.9
    • 0.9
    • Build Process
    • None
    • Windows, using Visual C++ to build compiler

    • Patch Available

    Description

      I tried to setup an environment on Windows. Rather than use a pre-built thrift.exe compiler, I built the compiler from source using Visual C++ (via compiler.vcxproj). While the compiler builds successfully, it is lacking generators for Delphi and D languages.

      When the compiler encounters a namespace directive in a .thrift file for a language, and it doesn't have a generator for that language, it throws an error.

      Therefore, this change adds the D and Delphi generators to the VC++ project.

      Additionally, some test thrift files use a very large integer constant (10 billion, too big for 32 bits). The windows-built compiler had strtoll #define'd to strtol, so it could not handle this large integer, so the test failed. This change defines strtoll as _stroi64, the VC++ equivalent, to fix that issue.

      Attachments

        Activity

          People

            andrewcox79 Andrew Cox
            andrewcox79 Andrew Cox
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: