Thrift
  1. Thrift
  2. THRIFT-1578

C_GLib generated code does not compile

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8, 0.9
    • Fix Version/s: 0.8, 0.9
    • Component/s: C glib - Compiler
    • Labels:
    • Environment:
    • Patch Info:
      Patch Available

      Description

      The problem is that the type name and the variable name does not have an empty space between them.

      1. thrift-1578-c_glib_generator.patch
        0.9 kB
        José Antonio Santos
      2. thrift-1578-c_glib_generator.patch
        0.9 kB
        José Antonio Santos

        Activity

        Hide
        Hudson added a comment -

        Integrated in Thrift #442 (See https://builds.apache.org/job/Thrift/442/)
        THRIFT-1583 c_glib leaks memory
        THRIFT-1578 C_GLib generated code does not compile
        THRIFT-1582 Bad includes of nested thrift files in c_glib

        Patch: José Antonio Santos
        Minor Modificatons by roger:

        • thrift prefix for includes
        • g_object_unref instead of g_clear_object (needs glib>=2.28) (Revision 1331752)

        Result = SUCCESS
        roger : http://svn.apache.org/viewvc/?view=rev&rev=1331752
        Files :

        • /thrift/trunk/compiler/cpp/src/generate/t_c_glib_generator.cc
        • /thrift/trunk/lib/c_glib/test/testbinaryprotocol.c
        • /thrift/trunk/lib/c_glib/test/testbufferedtransport.c
        • /thrift/trunk/lib/c_glib/test/testdebugproto.c
        • /thrift/trunk/lib/c_glib/test/testframedtransport.c
        • /thrift/trunk/lib/c_glib/test/testmemorybuffer.c
        • /thrift/trunk/lib/c_glib/test/testoptionalrequired.c
        • /thrift/trunk/lib/c_glib/test/teststruct.c
        • /thrift/trunk/lib/c_glib/test/testthrifttestclient.cpp
        • /thrift/trunk/lib/c_glib/test/testtransportsocket.c
        Show
        Hudson added a comment - Integrated in Thrift #442 (See https://builds.apache.org/job/Thrift/442/ ) THRIFT-1583 c_glib leaks memory THRIFT-1578 C_GLib generated code does not compile THRIFT-1582 Bad includes of nested thrift files in c_glib Patch: José Antonio Santos Minor Modificatons by roger: thrift prefix for includes g_object_unref instead of g_clear_object (needs glib>=2.28) (Revision 1331752) Result = SUCCESS roger : http://svn.apache.org/viewvc/?view=rev&rev=1331752 Files : /thrift/trunk/compiler/cpp/src/generate/t_c_glib_generator.cc /thrift/trunk/lib/c_glib/test/testbinaryprotocol.c /thrift/trunk/lib/c_glib/test/testbufferedtransport.c /thrift/trunk/lib/c_glib/test/testdebugproto.c /thrift/trunk/lib/c_glib/test/testframedtransport.c /thrift/trunk/lib/c_glib/test/testmemorybuffer.c /thrift/trunk/lib/c_glib/test/testoptionalrequired.c /thrift/trunk/lib/c_glib/test/teststruct.c /thrift/trunk/lib/c_glib/test/testthrifttestclient.cpp /thrift/trunk/lib/c_glib/test/testtransportsocket.c
        Hide
        Roger Meier added a comment -

        committed

        Show
        Roger Meier added a comment - committed
        Hide
        José Antonio Santos added a comment -

        Same file with the license aggreement (just in case is needed)

        Show
        José Antonio Santos added a comment - Same file with the license aggreement (just in case is needed)
        Hide
        José Antonio Santos added a comment -

        Patch that solves the issue.

        Show
        José Antonio Santos added a comment - Patch that solves the issue.

          People

          • Assignee:
            José Antonio Santos
            Reporter:
            José Antonio Santos
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development