[THRIFT-1577] Compile thrift with php module for php 5.4.0 failed. need to replace function_entry with zend_function_entry

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.8
• Component/s: PHP - Library
• Labels: patch php

Environment

CentOS 6.2 + PHP 5.4.0

• Patch Info: Patch Available
• Assignee: Unassigned
• Reporter: Matrix Ji
• Created: 17/Apr/12 13:18
• Updated: 11/May/12 00:41
• Resolved: 17/Apr/12 16:03

Description

As function_entry is dropped in php 5.4.0, compile thrift php-module with php 5.4.0 failed.
zend_function_entry should be used instead, which is available from php 5.0.0

I have already create a patch for thrift-0.8.0.

thrift-phpext.patch

diff -ru a/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp b/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp
--- a/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp	2012-03-21 08:17:30.000000000 +0800
+++ b/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp	2012-03-21 08:18:29.000000000 +0800
@@ -92,7 +92,7 @@
 #include "zend_exceptions.h"
 #include "php_thrift_protocol.h"
 
-static function_entry thrift_protocol_functions[] = {
+static zend_function_entry thrift_protocol_functions[] = {
   PHP_FE(thrift_protocol_write_binary, NULL)
   PHP_FE(thrift_protocol_read_binary, NULL)
   {NULL, NULL, NULL}