[THRIFT-1576] uint32_t used without including <stdint.h>

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9
• Component/s: C++ - Compiler, C++ - Library
• Labels: build-failure c++ cpp fb303

Environment

Ubuntu 11.10, Latest thrift source code

• Assignee: Unassigned
• Reporter: MXI MXI
• Created: 17/Apr/12 04:32
• Updated: 11/Oct/12 02:11
• Resolved: 07/Oct/12 19:50

Description

I need to build Scribe and one of its dependencies is fb303. I built fb303 inside latest thrift code "contrib/fb303" and encountered many errors.

It is similar to THRIFT-1060.

The steps to recreate:
./bootstrap.sh
./configure --without-ruby (Since I met THRIFT-1367 and couldn't overcome it)
make
sudo make install
cd contrib/fb303
./bootstrap.sh
./configure
make

Fail with multitude of errors.

gen-cpp/FacebookService.cpp:3146:8: error: 'class facebook::fb303::FacebookService_reinitialize_args' has no member named 'read'
gen-cpp/FacebookService.cpp:3147:10: error: 'class apache::thrift::protocol::TProtocol' has no member named 'readMessageEnd'
gen-cpp/FacebookService.cpp:3148:3: error: 'uint32_t' was not declared in this scope
gen-cpp/FacebookService.cpp:3148:12: error: expected ';' before 'bytes'
gen-cpp/FacebookService.cpp:3151:72: error: 'bytes' was not declared in this scope
gen-cpp/FacebookService.cpp: In member function 'void facebook::fb303::FacebookServiceProcessor::process_shutdown(int32_t, apache::thrift::protocol::TProtocol*, apache::thrift::protocol::TProtocol*, void*)':
gen-cpp/FacebookService.cpp:3183:8: error: 'class facebook::fb303::FacebookService_shutdown_args' has no member named 'read'
gen-cpp/FacebookService.cpp:3184:10: error: 'class apache::thrift::protocol::TProtocol' has no member named 'readMessageEnd'
gen-cpp/FacebookService.cpp:3185:3: error: 'uint32_t' was not declared in this scope
gen-cpp/FacebookService.cpp:3185:12: error: expected ';' before 'bytes'
gen-cpp/FacebookService.cpp:3188:68: error: 'bytes' was not declared in this scope
make[3]: *** [FacebookService.o] Error 1
make[3]: Leaving directory `/home/mxiixm/dev/thrift/trunk/contrib/fb303/cpp'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/mxiixm/dev/thrift/trunk/contrib/fb303/cpp'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/mxiixm/dev/thrift/trunk/contrib/fb303'
make: *** [all] Error 2

Please see the attached log file for more details.

Issue Links

• duplicates: THRIFT-1326 on some platforms, #include <stdint.h> is necessary to be included in Thrift.h