Thrift
  1. Thrift
  2. THRIFT-1539

Build and distribute the fb303 python libraries along with thrift

    Details

      Description

      Scribe, which is another project open sourced by Facebook, depends on fb303 which is hidden away in the contrib directory of Thrift. If the fb303 library could be uploaded to PyPI along with the thrift library, it would be a lot easier to build and install Scribe. This might also be relevant to do for all languages that distribute libraries used by generated code, not just Python.

      As far as I understand it, the fb303 library defines a useful API for long running services in general, so if it was distributed better, it might get a decent user base over time.

      PS.
      Yes, it seems silly that the Thrift project should maintain and distribute a library mostly (only?) used by a different, completely independent, project, but that's how Facebook decided to do it when they open sourced these things...

        Activity

        Morten Lied Johansen created issue -
        Jake Farrell made changes -
        Field Original Value New Value
        Assignee Jake Farrell [ jfarrell ]
        Hide
        Jake Farrell added a comment -

        Converting fb303 python build file over to setup for publishing to pypi and generating an egg with bdist_egg

        Show
        Jake Farrell added a comment - Converting fb303 python build file over to setup for publishing to pypi and generating an egg with bdist_egg
        Jake Farrell made changes -
        Attachment THRIFT-1539.patch [ 12527998 ]
        Hide
        Jake Farrell added a comment -

        will push this to pypi as an egg and src starting with the 0.9 release

        Show
        Jake Farrell added a comment - will push this to pypi as an egg and src starting with the 0.9 release
        Jake Farrell made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Fix Version/s 0.9 [ 12316294 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Thrift #474 (See https://builds.apache.org/job/Thrift/474/)
        THRIFT-1539:Build and distribute the fb303 python libraries along with thrift
        Client: contrib/fb303 - py
        Patch: Jake Farrell

        Updated build file so dist egg will include project headers, will publish with py client lib to pypi as part of release process. (Revision 1339967)

        Result = ABORTED
        jfarrell : http://svn.apache.org/viewvc/?view=rev&rev=1339967
        Files :

        • /thrift/trunk/contrib/fb303/py/setup.py
        Show
        Hudson added a comment - Integrated in Thrift #474 (See https://builds.apache.org/job/Thrift/474/ ) THRIFT-1539 :Build and distribute the fb303 python libraries along with thrift Client: contrib/fb303 - py Patch: Jake Farrell Updated build file so dist egg will include project headers, will publish with py client lib to pypi as part of release process. (Revision 1339967) Result = ABORTED jfarrell : http://svn.apache.org/viewvc/?view=rev&rev=1339967 Files : /thrift/trunk/contrib/fb303/py/setup.py

          People

          • Assignee:
            Jake Farrell
            Reporter:
            Morten Lied Johansen
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development