Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.6.1, 0.7, 0.8, 0.9, 1.0, 1.1
    • Fix Version/s: 0.9
    • Component/s: PHP - Library
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      There are two double function calls in the transport classes to strlen, which can easily prevented. See the attached patch file.

        Activity

        Hide
        Hudson added a comment -

        Integrated in Thrift #534 (See https://builds.apache.org/job/Thrift/534/)
        THRIFT-1521:patches for more Performance
        Client: php
        Patch: D. Edler

        Removes double function calls in the transport classes to strlen. (Revision 1390051)

        Result = SUCCESS
        jfarrell : http://svn.apache.org/viewvc/?view=rev&rev=1390051
        Files :

        • /thrift/trunk/lib/php/lib/Thrift/Transport/TMemoryBuffer.php
        Show
        Hudson added a comment - Integrated in Thrift #534 (See https://builds.apache.org/job/Thrift/534/ ) THRIFT-1521 :patches for more Performance Client: php Patch: D. Edler Removes double function calls in the transport classes to strlen. (Revision 1390051) Result = SUCCESS jfarrell : http://svn.apache.org/viewvc/?view=rev&rev=1390051 Files : /thrift/trunk/lib/php/lib/Thrift/Transport/TMemoryBuffer.php
        Hide
        Jake Farrell added a comment -

        committed

        Show
        Jake Farrell added a comment - committed
        Hide
        D. Edler added a comment -

        Fixes Performance.

        Show
        D. Edler added a comment - Fixes Performance.

          People

          • Assignee:
            Jake Farrell
            Reporter:
            D. Edler
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 10m
              10m
              Remaining:
              Remaining Estimate - 10m
              10m
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development