Thrift
  1. Thrift
  2. THRIFT-1502

TSimpleServer::serve(): Do not print out error message if server was stopped.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.8
    • Fix Version/s: 0.9
    • Component/s: C++ - Library
    • Labels:
    • Patch Info:
      Patch Available

      Description

      Currently, the following error message is displayed upon calling TSimpleServer::stop():

      "TServerTransport died on accept: TTransportException: Interrupted"

      The message originates from TSimpleServer::serve(). This message should not be displayed if the server came to a clean stop. I've provided a patch to fix this. This small fix is taken from the other servers, such as TThreadedServer, which do not have this issue.

      1. THRIFT-1502.patch
        0.8 kB
        Vibhav Sreekanti

        Activity

        Vibhav Sreekanti created issue -
        Vibhav Sreekanti made changes -
        Field Original Value New Value
        Attachment TSimpleServer_do_not_print_error_on_stop.patch [ 12511554 ]
        Vibhav Sreekanti made changes -
        Description Currently, the following error message is displayed upon calling
        TSimpleServer::stop():

            "TServerTransport died on accept: TTransportException: Interrupted"

        The message originates from TSimpleServer::serve(). This message should
        not be displayed if the server came to a clean stop. I've provided a
        patch to fix this. This small fix is taken from the other servers, such
        as TThreadedServer, which do not have this issue.
        Currently, the following error message is displayed upon calling TSimpleServer::stop():

            "TServerTransport died on accept: TTransportException: Interrupted"

        The message originates from TSimpleServer::serve(). This message should not be displayed if the server came to a clean stop. I've provided a patch to fix this. This small fix is taken from the other servers, such as TThreadedServer, which do not have this issue.
        Hide
        Diwaker Gupta added a comment -

        Trivial patch.

        Show
        Diwaker Gupta added a comment - Trivial patch.
        Diwaker Gupta made changes -
        Assignee Jake Farrell [ jfarrell ]
        Hide
        Vibhav Sreekanti added a comment -

        Identical patch. Renamed to match patch naming convention.

        Show
        Vibhav Sreekanti added a comment - Identical patch. Renamed to match patch naming convention.
        Vibhav Sreekanti made changes -
        Attachment THRIFT-1502.patch [ 12511558 ]
        Vibhav Sreekanti made changes -
        Attachment TSimpleServer_do_not_print_error_on_stop.patch [ 12511554 ]
        Hide
        Jake Farrell added a comment -

        committed

        Show
        Jake Farrell added a comment - committed
        Jake Farrell made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 0.9 [ 12316294 ]
        Resolution Fixed [ 1 ]
        Jake Farrell made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hudson added a comment -

        Integrated in Thrift #398 (See https://builds.apache.org/job/Thrift/398/)
        Thrift-1502:TSimpleServer::serve(): Do not print out error message if server was stopped.
        Client: cpp
        Patch: Vibhav Sreekanti

        Print msg on TSimpleServer stop.

        Show
        Hudson added a comment - Integrated in Thrift #398 (See https://builds.apache.org/job/Thrift/398/ ) Thrift-1502:TSimpleServer::serve(): Do not print out error message if server was stopped. Client: cpp Patch: Vibhav Sreekanti Print msg on TSimpleServer stop.

          People

          • Assignee:
            Jake Farrell
            Reporter:
            Vibhav Sreekanti
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development