Thrift
  1. Thrift
  2. THRIFT-1490

Windows-specific header files - fixes & tweaks

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.9
    • Fix Version/s: 0.9
    • Component/s: C++ - Library
    • Environment:

      Windows Visual Studio 2010

    • Patch Info:
      Patch Available

      Description

      This patch fixes some minor issues with the Windows config.h and TargetVersion.h files.

      TargetVersion.h:
      _WIN32_WINNT (and thus WINVER) was being forced to 0x0601, overriding project-specific settings. The generally accepted approach is to let the project set this and only define it if it's not already present.

      config.h:
      struct pollfd must be defined for a true XP compatible build (WINVER 0x501). This could not happen before when WINVER was being forced to 0x0601, causing the struct definition to be pulled in from a Vista+ header.
      Some other tweaks resolve compiler warnings.

      I've tested this by building the Thrift C++ libraries with VS2010, as well as our Windows projects that use Thrift. Please provide feedback if this causes any issues.

        Activity

        Hide
        Peace C added a comment -

        @Roger - Unix EOL for you

        Show
        Peace C added a comment - @Roger - Unix EOL for you
        Hide
        Roger Meier added a comment -

        committed, thanks Peace!

        Show
        Roger Meier added a comment - committed, thanks Peace!
        Hide
        Hudson added a comment -

        Integrated in Thrift #386 (See https://builds.apache.org/job/Thrift/386/)
        THRIFT-1490 Windows-specific header files - fixes & tweaks
        Patch: Peace C

        roger : http://svn.apache.org/viewvc/?view=rev&rev=1232397
        Files :

        • /thrift/trunk/lib/cpp/src/windows/TargetVersion.h
        • /thrift/trunk/lib/cpp/src/windows/config.h
        Show
        Hudson added a comment - Integrated in Thrift #386 (See https://builds.apache.org/job/Thrift/386/ ) THRIFT-1490 Windows-specific header files - fixes & tweaks Patch: Peace C roger : http://svn.apache.org/viewvc/?view=rev&rev=1232397 Files : /thrift/trunk/lib/cpp/src/windows/TargetVersion.h /thrift/trunk/lib/cpp/src/windows/config.h

          People

          • Assignee:
            Peace C
            Reporter:
            Peace C
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 24h
              24h
              Remaining:
              Remaining Estimate - 24h
              24h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development