Thrift
  1. Thrift
  2. THRIFT-1486

Javascript manual testserver not returning content types

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8
    • Fix Version/s: 0.9
    • Component/s: Test Suite
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      The testserver for javascript unit tests,

      lib/js/test$ ant testserver

      does not return Content-Type headers. As a result, the page does not render in a browser.

      1. THRIFT-1486.simple.patch
        1 kB
        Andrew Grumet
      2. THRIFT-1486.mimeutil.patch
        1 kB
        Andrew Grumet
      3. THRIFT-1486.mimeutil.patch
        1 kB
        Andrew Grumet

        Activity

        Hide
        Hudson added a comment -

        Integrated in Thrift #375 (See https://builds.apache.org/job/Thrift/375/)
        THRIFT-1486 Javascript manual testserver not returning content types
        Patch: Andrew Grumet

        roger : http://svn.apache.org/viewvc/?view=rev&rev=1228717
        Files :

        • /thrift/trunk/lib/js/test/build.xml
        • /thrift/trunk/lib/js/test/src/test/Httpd.java
        Show
        Hudson added a comment - Integrated in Thrift #375 (See https://builds.apache.org/job/Thrift/375/ ) THRIFT-1486 Javascript manual testserver not returning content types Patch: Andrew Grumet roger : http://svn.apache.org/viewvc/?view=rev&rev=1228717 Files : /thrift/trunk/lib/js/test/build.xml /thrift/trunk/lib/js/test/src/test/Httpd.java
        Hide
        Roger Meier added a comment -

        Thanks Andrew!
        Added the dependency to mime-util and committed!
        -Roger

        Show
        Roger Meier added a comment - Thanks Andrew! Added the dependency to mime-util and committed! -Roger
        Hide
        Andrew Grumet added a comment -

        Whitespace fix.

        Show
        Andrew Grumet added a comment - Whitespace fix.
        Hide
        Andrew Grumet added a comment -

        Choose either patch.

        THRIFT-1486.simple.patch is self-contained. It performs a simple, self-contained mime-type resolution.

        THRFIT-1468.mimeutil.patch uses the MimeUtil2 class (mime-util-2.1.3.jar). I wasn't able to determine how to add this as a dependency in maven. But if that can be done, this is a cleaner approach.

        Show
        Andrew Grumet added a comment - Choose either patch. THRIFT-1486 .simple.patch is self-contained. It performs a simple, self-contained mime-type resolution. THRFIT-1468.mimeutil.patch uses the MimeUtil2 class (mime-util-2.1.3.jar). I wasn't able to determine how to add this as a dependency in maven. But if that can be done, this is a cleaner approach.

          People

          • Assignee:
            Andrew Grumet
            Reporter:
            Andrew Grumet
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development