Thrift
  1. Thrift
  2. THRIFT-1473

JSON context stack may be left in an incorrect state when an exception is thrown during read or write operations

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8, 0.9
    • Fix Version/s: 0.8, 0.9
    • Component/s: Delphi - Library
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      The JSON context stack may be left in an incorrect state when an exception is thrown during read or write operations. This leads to further errors while writing/reading the NEXT message, because incorrect characters may be written or expected.

        Issue Links

          Activity

          Jens Geyer created issue -
          Hide
          Jens Geyer added a comment -

          Patch suitable for 0.8.0 and 0.9.0

          Show
          Jens Geyer added a comment - Patch suitable for 0.8.0 and 0.9.0
          Jens Geyer made changes -
          Field Original Value New Value
          Attachment THRIFT-1473_JSON_context_stack_left_in_incorrect_state_after_exception.patch [ 12508178 ]
          Jens Geyer made changes -
          Attachment THRIFT-1473_JSON_context_stack_left_in_incorrect_state_after_exception.patch [ 12508178 ]
          Hide
          Jens Geyer added a comment -

          Patch suitable for 0.8.0. and 0.9.0

          Show
          Jens Geyer added a comment - Patch suitable for 0.8.0. and 0.9.0
          Jens Geyer made changes -
          Link This issue blocks THRIFT-1485 [ THRIFT-1485 ]
          Hide
          Kenjiro Fukumitsu added a comment - - edited

          I reviewed this patch and found no problem.
          It passed test case on my machine. +1.

          Show
          Kenjiro Fukumitsu added a comment - - edited I reviewed this patch and found no problem. It passed test case on my machine. +1.
          Hide
          Roger Meier added a comment -

          Thanks Jens and Kenjiro, committed!

          Show
          Roger Meier added a comment - Thanks Jens and Kenjiro, committed!
          Roger Meier made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Assignee Jens Geyer [ jensg ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Thrift #376 (See https://builds.apache.org/job/Thrift/376/)
          THRIFT-1473 JSON context stack may be left in an incorrect state when an exception is thrown during read or write operations
          Patch: Jens Geyer

          roger : http://svn.apache.org/viewvc/?view=rev&rev=1228963
          Files :

          • /thrift/trunk/lib/delphi/src/Thrift.Protocol.JSON.pas
          Show
          Hudson added a comment - Integrated in Thrift #376 (See https://builds.apache.org/job/Thrift/376/ ) THRIFT-1473 JSON context stack may be left in an incorrect state when an exception is thrown during read or write operations Patch: Jens Geyer roger : http://svn.apache.org/viewvc/?view=rev&rev=1228963 Files : /thrift/trunk/lib/delphi/src/Thrift.Protocol.JSON.pas
          Jake Farrell made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Link This issue blocks THRIFT-1485 [ THRIFT-1485 ]
          Gavin made changes -
          Link This issue is depended upon by THRIFT-1485 [ THRIFT-1485 ]

            People

            • Assignee:
              Jens Geyer
              Reporter:
              Jens Geyer
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development