[THRIFT-1455] TBinaryProtocolT<Transport_>::writeString casts from size_t to uint32_t, which is not safe on 64-bit platforms

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.9.2
• Component/s: C++ - Library

Environment

gcc 4.4.4, 64 bit Linux (with -Werror and -Wconversion compile flags)

• Assignee: Ben Craig
• Reporter: Bob Callaway
• Created: 08/Dec/11 18:05
• Updated: 03/Sep/13 21:11
• Resolved: 28/Aug/13 21:45

Description

The first line in this method sets the size based on the string length, which is of size_t type. On a 64-bit platform, the cast from a 64 bit unsigned integer to a 32 bit unsigned integer can result in incomplete data being written.

With my compiler flags (-Werror and -Wconversion), I can't compile my code that includes the client library headers.