[THRIFT-1453] Don't change types of arguments when serializing with thrift php extension

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.9
• Component/s: C++ - Library
• Assignee: Dave Watson
• Reporter: Dave Watson
• Created: 07/Dec/11 22:20
• Updated: 24/Jan/14 09:00
• Resolved: 28/Jan/12 03:59

Description

From c630a1a3d7485678176c53e365d20b38db17f8bd Mon Sep 17 00:00:00 2001
From: Dan 'Sabretooth' Weatherford <[e-mail]>
Date: Fri, 25 Jun 2010 03:39:58 +0000
Subject: [PATCH 4/5] Don't change types of arguments when serializing with thrift php extension

Summary:
If the PHP variable type is not compatible with the desired serialization type,
we'll copy the variable before doing the conversion. If it is compatible, this
just adds a little refcount fiddling, so it shouldn't slow down much.

Test Plan:
Passed a bool, int, and double to functions expecting strings, and verified
that the types were unchanged afterwards. (Previously, they'd all end up as
strings.)

DiffCamp Revision: 126908
Reviewed By: dreiss
CC: dreiss, kholst, thrift-team@lists
Revert Plan:
OK