Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1445

minor C++ generator variable cleanup

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.8
    • C++ - Library
    • None

    Description

      From 5d5a0a42e5a20c9fc72d686c880614f6568a992e Mon Sep 17 00:00:00 2001
      From: Adam Simpkins <simpkins@fb.com>
      Date: Mon, 14 Jun 2010 19:52:15 +0000
      Subject: [PATCH 04/56] minor C++ generator variable cleanup

      Summary:
      In generate_process_function(), service_func_name is always used as a
      string literal. Therefore, construct it with the double quotes
      built-in, rather than having to add them everywhere we use it.

      Test Plan:
      Built [two internal fb projects]

      DiffCamp Revision: 122187
      Reviewed By: dreiss
      CC: dreiss, kholst, thrift-team@lists
      Revert Plan:
      OK

      git-svn-id: svn+ssh://tubbs/svnapps/fbomb/trunk/[internal fb thing]@29905 2248de34-8caa-4a3c-bc55-5e52d9d7b73a

      compiler/cpp/src/generate/t_cpp_generator.cc | 90 +++++++++++++-------------
      1 files changed, 45 insertions, 45 deletions

      Attachments

        Activity

          People

            davejwatson@fb Dave Watson
            davejwatson@fb Dave Watson
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: