Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.7
    • Fix Version/s: 0.8
    • Component/s: Node.js - Library
    • Labels:
    • Environment:

      NodeJs greater than 0.3.0

      Description

      Since version 0.3.0 (2010.10.23, http://nodejs.org/changelog.html), the 'sys' module was renamed 'util' while keeping the same API.

        Activity

        Hide
        Jake Farrell added a comment -

        Roger, can you take a look at this

        Show
        Jake Farrell added a comment - Roger, can you take a look at this
        Hide
        Roger Meier added a comment -

        committed.

        Could you please create the patch from thrift source root directory?
        This makes it much easier to handle.

        If you have some spare time... we need a test suite for node.js THRIFT-1134

        Show
        Roger Meier added a comment - committed. Could you please create the patch from thrift source root directory? This makes it much easier to handle. If you have some spare time... we need a test suite for node.js THRIFT-1134
        Hide
        David Worms added a comment - - edited

        Just so I know how to do it, as far as i remember, I issued `svn diff > file.diff` from the Thrift root directory, is it not correct? I missed github: ) I might take a look at the test case but not before a few weeks. Thanks for applying the patch. Also, I dont think you should wait to publish those changes to NPM.

        Show
        David Worms added a comment - - edited Just so I know how to do it, as far as i remember, I issued `svn diff > file.diff` from the Thrift root directory, is it not correct? I missed github: ) I might take a look at the test case but not before a few weeks. Thanks for applying the patch. Also, I dont think you should wait to publish those changes to NPM.
        Hide
        Hudson added a comment -

        Integrated in Thrift #341 (See https://builds.apache.org/job/Thrift/341/)
        THRIFT-1431 Rename 'sys' module to 'util'
        Patch: David Worms

        roger : http://svn.apache.org/viewvc/?view=rev&rev=1205576
        Files :

        • /thrift/trunk/.gitignore
        • /thrift/trunk/lib/nodejs/lib/thrift/binary_parser.js
        • /thrift/trunk/lib/nodejs/lib/thrift/connection.js
        • /thrift/trunk/lib/nodejs/lib/thrift/protocol.js
        • /thrift/trunk/lib/nodejs/lib/thrift/server.js
        • /thrift/trunk/lib/nodejs/lib/thrift/thrift.js
        Show
        Hudson added a comment - Integrated in Thrift #341 (See https://builds.apache.org/job/Thrift/341/ ) THRIFT-1431 Rename 'sys' module to 'util' Patch: David Worms roger : http://svn.apache.org/viewvc/?view=rev&rev=1205576 Files : /thrift/trunk/.gitignore /thrift/trunk/lib/nodejs/lib/thrift/binary_parser.js /thrift/trunk/lib/nodejs/lib/thrift/connection.js /thrift/trunk/lib/nodejs/lib/thrift/protocol.js /thrift/trunk/lib/nodejs/lib/thrift/server.js /thrift/trunk/lib/nodejs/lib/thrift/thrift.js
        Hide
        Jake Farrell added a comment -

        David, we will push this change to NPM with the 0.8 release when it is out, we do not update the clients per patch change

        Show
        Jake Farrell added a comment - David, we will push this change to NPM with the 0.8 release when it is out, we do not update the clients per patch change

          People

          • Assignee:
            Roger Meier
            Reporter:
            David Worms
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development