Thrift
  1. Thrift
  2. THRIFT-1413

Generated code does not read MapEnd / ListEnd / SetEnd

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8
    • Fix Version/s: 0.8
    • Component/s: Delphi - Compiler
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      The generated code lacks calls to ReadMapEnd, ReadListEnd and ReadSetEnd. Although actually no problem occurs with the BinaryProtocol, other protocols (like JSON) do some important things there.

        Activity

        Hide
        Hudson added a comment -

        Integrated in Thrift #310 (See https://builds.apache.org/job/Thrift/310/)
        THRIFT-1413: Generated code does not read MapEnd / ListEnd / SetEnd
        Client: delphi
        Patch: Jens Geyer

        The generated code lacks calls to ReadMapEnd, ReadListEnd and ReadSetEnd. Although actually no problem occurs with the BinaryProtocol, other protocols (like JSON) do some important things there.

        jfarrell : http://svn.apache.org/viewvc/?view=rev&rev=1195466
        Files :

        • /thrift/trunk/compiler/cpp/src/generate/t_delphi_generator.cc
        Show
        Hudson added a comment - Integrated in Thrift #310 (See https://builds.apache.org/job/Thrift/310/ ) THRIFT-1413 : Generated code does not read MapEnd / ListEnd / SetEnd Client: delphi Patch: Jens Geyer The generated code lacks calls to ReadMapEnd, ReadListEnd and ReadSetEnd. Although actually no problem occurs with the BinaryProtocol, other protocols (like JSON) do some important things there. jfarrell : http://svn.apache.org/viewvc/?view=rev&rev=1195466 Files : /thrift/trunk/compiler/cpp/src/generate/t_delphi_generator.cc
        Hide
        Jake Farrell added a comment -

        Committed

        Show
        Jake Farrell added a comment - Committed
        Hide
        Kenjiro Fukumitsu added a comment -

        Thanks, Jens.This patch works great.

        Show
        Kenjiro Fukumitsu added a comment - Thanks, Jens.This patch works great.
        Hide
        Jens Geyer added a comment -

        FIX: Added the missing codeblock in the generator.

        Show
        Jens Geyer added a comment - FIX: Added the missing codeblock in the generator.

          People

          • Assignee:
            Jens Geyer
            Reporter:
            Jens Geyer
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development