Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1373

Fix user-defined exception generation in thrift (python)

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.8
    • C++ - Library
    • None

    Description

      From 85a1ebf8d439ccb71db2c2fd586949f563339be7 Mon Sep 17 00:00:00 2001
      From: Doug Ihde <dihde@fb.com>
      Date: Fri, 29 Jan 2010 19:45:23 +0000
      Subject: [PATCH 1/9] Fix user-defined exception generation in thrift (python)

      Summary: Fixed python code generation so that user-defined exceptions have a
      base class of TException rather than Exception.

      Test Plan: Build [a facebook project] which is a python test
      client. Run the test client with
      invalid args so that the server throws an exception. Ensure
      that exception is properly returned to the test client
      with the "message" field set and without warning
      "Exception.message has been deprecated in Python 2.6".

      Conflicts:

      compiler/cpp/src/generate/t_py_generator.cc

      compiler/cpp/src/generate/t_py_generator.cc | 2 +-
      1 files changed, 1 insertions, 1 deletions

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            davejwatson@fb Dave Watson
            davejwatson@fb Dave Watson
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment