[THRIFT-135] Nulls in set<string> throw an exception in Java

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Fix Version/s: 0.3
• Component/s: Java - Compiler
• Assignee: Unassigned
• Reporter: David Reiss
• Created: 08/Sep/08 17:37
• Updated: 26/Mar/10 23:14
• Resolved: 26/Mar/10 23:14

Description

From Amit Sudharshan:

I recently noticed a bug(feature?) in com.facebook.thrift.protocol.TBinaryProtocol.writeString where if it is passed a null pointer it will throw NPE.

Now, the autogenerated stub code tries to prevent this, however we recently came across a case where we had a Set<String> which contained a "NULL" (legal in java). Thrift tests to see if the set is non-null and implicitely whether it has any elements, both of these pass in this case, and so the null string is passed to the writeString method where we get the NPE.

Issue Links

• is related to: THRIFT-226 Collections with binary keys or values break equals()