[THRIFT-1356] Memory leak and other issues in TSocketClient

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Won't Do
• Affects Version/s: 0.7
• Fix Version/s: 0.13.0
• Component/s: Cocoa - Library

Environment

iOS 4.3

• Patch Info: Patch Available
• Assignee: James E. King III
• Reporter: Matthew Phillips
• Created: 23/Sep/11 08:37
• Updated: 10/Oct/19 23:00
• Resolved: 14/Jan/19 15:03

Description

The socket setup code in TSocketClient seems to have been copied blindly from Apple's docs. The two problems with that are:

(a) The example is for non-blocking event-based network IO, but Thrift uses it in blocking mode and does not handle the delegate events it registers for. This causes network operations to randomly hang.

(b) It retains the input and output streams, which already have a retain count of 1, and which are then retained again by the superclass, causing a memory leak.