[THRIFT-1351] Compiler does not care about binary strings

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.7
• Fix Version/s: 0.10.0
• Component/s: Node.js - Compiler
• Labels: compiler node nodejs
• Assignee: Wade Simmons
• Reporter: Hans Duedal
• Created: 22/Sep/11 12:11
• Updated: 12/Aug/16 01:29
• Resolved: 08/Apr/16 05:45

Description

The node.js lib has support for binary strings, but the compiler does not check for it.

It's quite easily fixed:
https://github.com/onlinecity/thrift/commit/1d86faa2f44c7b8db80595375d6bd0b9b678c0ee

With the fix node.js server implementations can operate on binary arguments.

Issue Links

• depends upon: THRIFT-1353 Switch to performance branch, get rid of BinaryParser
• is duplicated by: THRIFT-1841 NodeJS Thrift incorrectly parses non-UTF8-string types
• is duplicated by: THRIFT-2363 Issue with character encoding of Success returned from Login using Thrift Proxy and NodeJS