Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-1322

OCaml lib fail to compile: Thrift.ml line 305, int vs int32 mismatch

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • None
    • 0.8
    • OCaml - Library
    • None
    • Mac OS 10.6.8, 64bits x86_64

    Description

      Between SVN of 20110418 and today, the lib/ocaml has ceased to build.
      I mean it did build on april 18, not lately.

      The build die in this way:

      – 8< –

      philou@air:~/src/thrift-svn/lib/ocaml$ make
      cd src; make; cd ..
      ocamlopt -c -thread Thrift.ml
      File "Thrift.ml", line 305, characters 6-8:
      Error: This pattern matches values of type int
      but a pattern was expected which matches values of type int32

      – 8< –

      The lib/ocaml changes between 20110418 and 20110905 are listed below, and rather thin, should not be a big deal to fix :

      diff -ur thrift-svn-20110418/lib/ocaml/src/Thrift.ml thrift-svn/lib/ocaml/src/Thrift.ml
      — thrift-svn-20110418/lib/ocaml/src/Thrift.ml 2011-04-13 18:38:21.000000000 +0200
      +++ thrift-svn/lib/ocaml/src/Thrift.ml 2011-08-03 16:10:25.000000000 +0200
      @@ -292,6 +292,8 @@

      WRONG_METHOD_NAME
      BAD_SEQUENCE_ID
      MISSING_RESULT
      +
      INTERNAL_ERROR
      +
      PROTOCOL_ERROR

      let typ_of_i = function
      0l -> UNKNOWN
      @@ -300,6 +302,8 @@

      3l -> WRONG_METHOD_NAME
      4l -> BAD_SEQUENCE_ID
      5l -> MISSING_RESULT
      +
      61 -> INTERNAL_ERROR
      +
      71 -> PROTOCOL_ERROR
      _ -> raise Thrift_error;;
      let typ_to_i = function
      UNKNOWN -> 0l
      @@ -308,6 +312,8 @@
      WRONG_METHOD_NAME -> 3l
      BAD_SEQUENCE_ID -> 4l
      MISSING_RESULT -> 5l
      +
      INTERNAL_ERROR -> 61
      +
      PROTOCOL_ERROR -> 71

      class t =
      object (self)

      Attachments

        Activity

          People

            jfarrell Jake Farrell
            philou@philou.ch Philippe STRAUSS
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 20m
                20m
                Remaining:
                Remaining Estimate - 20m
                20m
                Logged:
                Time Spent - Not Specified
                Not Specified