[THRIFT-1305] thrift: make TConnection a private inner class of

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.8
• Component/s: C++ - Library
• Assignee: Dave Watson
• Reporter: Dave Watson
• Created: 29/Aug/11 15:31
• Updated: 01/Sep/11 17:41
• Resolved: 01/Sep/11 16:51

Description

From 1f203754d8e9eb3e509cd874f6e5824eeaf5aa34 Mon Sep 17 00:00:00 2001
From: Adam Simpkins <[e-mail]>
Date: Mon, 19 Apr 2010 19:09:13 +0000
Subject: [PATCH 24/33] thrift: make TConnection a private inner class of
TNonblockingServer

Summary:
The immediate need for this is so that TConnection can access some
protected methods of TNonblockingServer. However, it
seems a generally good thing to eliminate TConnection from the publicly
exposed API.

Test Plan:
Ran the tests from [fb unittest].

Revert Plan:
OK

Conflicts:

lib/cpp/src/server/TNonblockingServer.cpp
lib/cpp/src/server/TNonblockingServer.h
—
lib/cpp/src/server/TNonblockingServer.cpp | 301 +++++++++++++++++++++++++++--
lib/cpp/src/server/TNonblockingServer.h | 275 +--------------------------
2 files changed, 291 insertions, 285 deletions