[THRIFT-1304] TNonblockingServer: pass in the connection context to

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.8
• Component/s: C++ - Library
• Assignee: Dave Watson
• Reporter: Dave Watson
• Created: 29/Aug/11 15:30
• Updated: 29/Aug/11 19:16
• Resolved: 29/Aug/11 18:50

Description

From aa5cdf5b40e046b41a0c61e521dba0e78e1887b0 Mon Sep 17 00:00:00 2001
From: Adam Simpkins <[e-mail]>
Date: Sat, 17 Apr 2010 01:10:15 +0000
Subject: [PATCH 23/33] TNonblockingServer: pass in the connection context to
process()

Summary:
When using TNonblockingServer without a ThreadManager, it always passed
NULL to process(), instead of passing in the context returned by
TProcessorEventHandler::getContext(). This was broken and could cause
TProcessorEventHandlers to crash, since they expected to get the value
they had previously returned via getContext().

Test Plan:
Ran the test code in [fb unittest]. The non-threaded TNonblockingServer tests
no longer crash.

Revert Plan:
OK

—
lib/cpp/src/server/TNonblockingServer.cpp | 3 ++-
1 files changed, 2 insertions, 1 deletions